[Intel-gfx] [PATCH] drm/i915: Detect lvds channel according to fixed mode line

[Florian Mickler]

On Thu, 16 Jul 2009 13:37:21 +0200
Florian Mickler <florian at mickler.org> wrote:

> On Thu, 16 Jul 2009 17:23:10 +0800
> ling.ma at intel.com wrote:
> 
> > As vbios does, detect lvds channel type by following steps:
> > (We use lvds fixed mode line regardless of EDID available)
> > 1. Set lvds single channel as default
> > 2. If DTD.hdisplay < 1280, return, or go to step 3
> > 3. If DTD.vdisplay < 800/1024 return, or go to setp 4
> > 4. Set dual lvds channel.
> 
> s/or/else/
> 
> 
> > 
> > Signed-off-by: Ma Ling <ling.ma at intel.com>
> 
> Tested-By: Florian Mickler <florian at mickler.org>
> 
> i tested this commit and it fixes bug #22262 for me. 

sorry, i tested a similar patch. (see comment in bug 22262) 

this has a Problem which results in a oops or bug or panic at boot
time. 

> > +static void intel_lvds_detect_channel_type(struct drm_device *dev)
> > +{
> > +	struct drm_i915_private *dev_priv = dev->dev_private;
> > +	int hdisplay, vdisplay;
> > +
> > +	/* Default to Single Channel */
> > +	dev_priv->lvds_is_dual_channel = false;
> > +
> > +	hdisplay = 1280;
> > +	if (IS_GM45(dev))
> > +		vdisplay = 801; /*vdisplay <= 800 is for single
> > channel*/
> > +	else
> > +		vdisplay = 1024;
> > +
> > +
> > +	if (dev_priv->panel_fixed_mode->hdisplay >= hdisplay &&
> > +	    dev_priv->panel_fixed_mode->vdisplay >= vdisplay)
> > +		dev_priv->lvds_is_dual_channel = true;
> > +
> > +}

this hunk was different in my tested patch. there was no 
if (IS_GM45(dev)) 

Sincerely,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090717/44dd9518/attachment.sig>