[Intel-gfx] [PATCH 15/17] drm/i915: Use drm_helper_connector_dpms for DisplayPort

Eric Anholt eric at anholt.net
Fri Jun 5 15:21:04 CEST 2009


On Sat, 2009-05-30 at 20:42 -0700, Keith Packard wrote:
> Signed-off-by: Keith Packard <keithp at keithp.com>

gratuitous move of code in this commit?

> ---
>  drivers/gpu/drm/i915/intel_dp.c |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 56b0119..c9dd28b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1041,7 +1041,14 @@ static const struct drm_encoder_helper_funcs intel_dp_helper_funcs = {
>  	.commit = intel_encoder_commit,
>  };
>  
> +static const struct drm_connector_helper_funcs intel_dp_connector_helper_funcs = {
> +	.get_modes = intel_dp_get_modes,
> +	.mode_valid = intel_dp_mode_valid,
> +	.best_encoder = intel_best_encoder,
> +};
> +
>  static const struct drm_connector_funcs intel_dp_connector_funcs = {
> +	.dpms = drm_helper_connector_dpms,
>  	.save = intel_dp_save,
>  	.restore = intel_dp_restore,
>  	.detect = intel_dp_detect,
> @@ -1049,12 +1056,6 @@ static const struct drm_connector_funcs intel_dp_connector_funcs = {
>  	.destroy = intel_dp_destroy,
>  };
>  
> -static const struct drm_connector_helper_funcs intel_dp_connector_helper_funcs = {
> -	.get_modes = intel_dp_get_modes,
> -	.mode_valid = intel_dp_mode_valid,
> -	.best_encoder = intel_best_encoder,
> -};
> -
>  static void intel_dp_enc_destroy(struct drm_encoder *encoder)
>  {
>  	drm_encoder_cleanup(encoder);
-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090605/756df716/attachment.sig>


More information about the Intel-gfx mailing list