[Intel-gfx] DVI/HDMI regression due to 30ad48b7334a2eb2edf22f6c91f7b3f22a22a837

[Zhenyu Wang]

On 2009.06.16 17:25:55 -0700, Jesse Barnes wrote:
> Zhenyu's commit to add IGDNG support broke my G45 configuration.  It
> looks like my config breaks when the SDVO_NULL_PACKETS_DURING_VSYNC bit
> is set in the SDVO mode reg (I have a dual head config with HDMI and
> DVI).  Not setting the bit allows both displays to work.  Setting it
> causes a corrupted mode on my HDMI attached display and a blank screen
> on the DVI attached one.
> 
> Any ideas here Zhenyu?
> 

I did testing on new chipset, and it looks NULL_PACKETS_DURING_VSYNC was
wrongly added, that isn't required. So here's the patch to remove it.

Thanks.

From 9e2f0f55c101b9b99062194c39c1fc51ee6b4060 Mon Sep 17 00:00:00 2001
From: Zhenyu Wang <zhenyuw at linux.intel.com>
Date: Wed, 17 Jun 2009 09:30:51 +0800
Subject: [PATCH] drm/i915: Fix HDMI regression introduced in new chipset support

Remove wrongly added NULL_PACKETS_DURING_VSYNC setting for HDMI.

Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index d874b0c..f48a028 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -56,8 +56,7 @@ static void intel_hdmi_mode_set(struct drm_encoder *encoder,
 	sdvox = SDVO_ENCODING_HDMI |
 		SDVO_BORDER_ENABLE |
 		SDVO_VSYNC_ACTIVE_HIGH |
-		SDVO_HSYNC_ACTIVE_HIGH |
-		SDVO_NULL_PACKETS_DURING_VSYNC;
+		SDVO_HSYNC_ACTIVE_HIGH;
 
 	if (hdmi_priv->has_hdmi_sink)
 		sdvox |= SDVO_AUDIO_ENABLE;
-- 
1.6.3.1


-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090617/14a99be3/attachment.sig>