[Intel-gfx] [PATCH 6/6] drm/i915: Final split into two modules
rpurdie at linux.intel.com
Thu Jun 18 21:20:30 CEST 2009
On Thu, 2009-06-18 at 11:03 -0700, Eric Anholt wrote:
> On Wed, 2009-05-13 at 15:03 +0100, Richard Purdie wrote:
> > This patch finished splitting the i915 module into two parts, a common
> > intel_vdc module which can be used by other drivers and a separate
> > i915 module.
> So, my basic problem with this series is:
> 39 files changed, 662 insertions(+), 476 deletions(-)
> This is a lot of churn for something that doesn't end with "makes the
> driver better in a significant way." I think I'll hold off on these
> patches until they're part of a series doing something in particular.
Well, we agreed the code needs some kind of refactoring and these
patches simply separate the code as we've discussed into some logical
units. We have to start that somewhere, the diffstat result isn't
exactly a surprise and these patches do have merit on their own as a
cleanup and logical separation.
But if now isn't the time for them, that is your call. I just wish this
had been mentioned when we previous discussed it.
More information about the Intel-gfx