[Intel-gfx] [PATCH] Fix segv for clipped movie window

Barry Scott barry.scott at onelan.co.uk
Tue Jun 23 15:14:50 CEST 2009

When playing a movie that is clipped on its left and right edges the 
Xorg server will SEGV
sometimes. This is because the intel driver ignores the clipping info 
when it copies
the planes out of the XV data.

The check for the optimised copy was wrong to ignore the width required. 
Which leads
to too much data being copied by the memcpy. It the source buffer 
happens to end
exactly on a page boundary the server will SEGV.

As we reviewed the code we checked the calculation of src1, src2 and 
src3. The
patch includes additional comments to make it clear what the elements of the
calculation are.

This bug exists in git head and we also see it in 2.4.1.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_video_clipping_segv.patch
Type: text/x-patch
Size: 2542 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090623/1636e0dd/attachment.bin>

More information about the Intel-gfx mailing list