[Intel-gfx] [PATCH 1/2] set output clone mask to share the same pipe.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Rémi Cardona wrote:
> Le 29/06/2009 17:30, ling.ma at intel.com a écrit :
>>       i830_output->clone_mask = ((1<<  I830_OUTPUT_ANALOG) |
>> +                               (1<<  I830_OUTPUT_SDVO) |
>> +                               (1<<  I830_OUTPUT_SDVO_LVDS) |
>>   			       (1<<  I830_OUTPUT_DVO_TMDS));
>                                 ^^^^ weird indent

The original code is just indented incorrectly.

>>         output->possible_crtcs = crtc_mask;
>>         output->possible_clones = i830_output_clones (pScrn, intel_output->clone_mask);
>> +      xf86DrvMsg(output->scrn->scrnIndex, X_INFO, "possible clones of output %s is %x ",
>> +		      output->name,output->possible_clones);
>           ^^ weird indent

I think most of these are some sort of mixed tabs / spaces problems.
I'm guessing the code looks fine outside of patch form.

>>       intel_output->dev_priv = dev_priv;
>> -    intel_output->type = I830_OUTPUT_HDMI;
>>       intel_output->pipe_mask = ((1<<  0) | (1<<  1));
>> -    intel_output->clone_mask = (1<<  I830_OUTPUT_HDMI);
> 
>         ^^ ditto
> 
>>       /* Set up the DDC bus. */
>> -    if (output_reg == SDVOB)
>> +    if (output_reg == SDVOB) {
>> +        intel_output->type = I830_OUTPUT_HDMIB;
>> +        intel_output->clone_mask = (1<<  I830_OUTPUT_HDMIB);
>>   	I830I2CInit(pScrn,&intel_output->pDDCBus, GPIOE, "HDMIDDC_B");
>          ^^^^ here too
> 
>> -    else
>> +    } else {
>> +        intel_output->type = I830_OUTPUT_HDMIC;
>> +        intel_output->clone_mask = (1<<  I830_OUTPUT_HDMIC);
>>   	I830I2CInit(pScrn,&intel_output->pDDCBus, GPIOD, "HDMIDDC_C");
>          ^^^^ there
> 
> 
> 
>>   	intel_output->needs_tv_clock = TRUE;
>> +        intel_output->clone_mask = 1<<  I830_OUTPUT_SDVO_TV;
>          ^^^^
> 
>>   	intel_output->needs_tv_clock = TRUE;
>> +        intel_output->clone_mask = 1<<  I830_OUTPUT_SDVO_TV;
>          ^^^^
> 
> 
>>           dev_priv->is_lvds = TRUE;
>> +        intel_output->clone_mask = ((1<<  I830_OUTPUT_SDVO_LVDS) |
>             ^^ and there too
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpJHqcACgkQX1gOwKyEAw9u5gCdFE+BKu7EWMPJ0qcdCDDVbG2D
nPcAnRMCqnn/rz4QGJ8RT9Aj5yzT4SVp
=QyBW
-----END PGP SIGNATURE-----