[Intel-gfx] [PATCH 3/3] Add a more debug registers to ringbuffer_info

Carl Worth cworth at cworth.org
Fri Mar 20 22:02:13 CET 2009


On Fri, 2009-03-20 at 13:49 -0700, Eric Anholt wrote:
> On Fri, 2009-03-20 at 11:54 -0700, Carl Worth wrote:
> If we're putting in performance counter-ish regs like INSTDONE (the 965
> stats regs can be used pretty similarly to INSTDONE to get more
> granularity on what's going on), we might want to put them in a separate
> node.  Not sure.  If not, we might just squash this patch into the
> previous one.
> 
> Pretty satisfied with the first two in the series, though.  Needs
> Signed-off-by: and we're probably ready.

Thanks for the review.

I really hadn't looked at the third patch at all yet. Let's hold off on
it until we look closer to see what we really want, (and waiting
shouldn't impact the immediate debugging that we want to do with the
first two patches).

-Carl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090320/7c4d6991/attachment.sig>


More information about the Intel-gfx mailing list