[Intel-gfx] [PATCH] KMS: clean up udelay usage

Jesse Barnes jbarnes at virtuousgeek.org
Sat Mar 28 00:08:27 CET 2009


On Mon, 23 Mar 2009 13:47:33 -0700
Arjan van de Ven <arjan at infradead.org> wrote:

> >From 04795556b9ef5cd036a182535d04c4c853b61c96 Mon Sep 17 00:00:00
> >2001
> From: Arjan van de Ven <arjan at linux.intel.com>
> Date: Mon, 23 Mar 2009 13:36:25 -0700
> Subject: [PATCH] KMS: clean up udelay usage
> 
> udelay() of 20 milliseconds really ought to just use mdelay(), that
> avoids the various wrap scenarios and also is more readable
> 
> Signed-off-by: Arjan van de Ven <arjan at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index c0ab079..6f2eced 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -319,7 +319,7 @@ void
>  intel_wait_for_vblank(struct drm_device *dev)
>  {
>  	/* Wait for 20ms, i.e. one cycle at 50hz. */
> -	udelay(20000);
> +	mdelay(20);
>  }
>  
>  static int

Yeah, looks fine.  Hopefully Eric can pick it up soon.

Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list