[Intel-gfx] [PATCH 3/3] XvMC: Hack up zero-copy bo passthrough to work with kms

[Zhenyu Wang]

On 2009.10.26 14:15:26 +0100, Daniel Vetter wrote:
> This partially reverts

Sorry for late review.

> 
> commit f171069608bf174d920921fa102b8619794ed272
> Author: Zhenyu Wang <zhenyuw at linux.intel.com>
> Date:   Mon Sep 28 18:35:57 2009 +0800
> 
>     i965 XvMC cleanup
> 
> because:
> - the hack used there only works for i965, not for the XvMC code for
>   i915. I prefer consistent ugly hacks over inconsistent ones.

I don't think that's a 'hack', but a solution, and it's under IS_I965G().
It seems i915 XvMC got no lover, and it needs full rework to be back to work
in current world.

The idea in my patch is simple, XvMC surface is just hw decoded image data like
Xv image, so I tried to remove origin ugly code that tried to differentiate it,
which is totally unnecessary. Yeah, it's only for i965.

> - the changes to the xvmc_passthrough as forward-ported by Eric Anholt
>   definitely breaks XvMC on Xv overlay with rotated crtc. Yep, it's
>   totally unlikely anyone is using this, but still, try to keep it
>   a supported config working.
> 

But XvMC never works on overlay port, XvMC requires a specific Xv adapter
assigned to it when init, and current code only gives texture video adapter
to XvMC.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091102/ebdace2d/attachment.sig>