[Intel-gfx] Xv overlay in git master

[Maxim Levitsky]

On Fri, 2009-10-23 at 14:12 +0200, Daniel Vetter wrote:
> On Thu, Oct 22, 2009 at 08:20:03AM -0700, Eric Anholt wrote:
> > On Thu, 2009-10-22 at 09:38 +0200, Tino Keitel wrote:
> > > Hi,
> > > 
> > > I read about Xv overlay support in some commits in git master. Should
> > > this be already functional? I tested the version at commit
> > > 751e0a3e4576bbf4bffa56bbd6d4de28f10db98e, with kernel 2.6.32-rc5 and
> > > Xserver 1.7, but only got textured video.
> > 
> > The kernel support is in -next, and the 2d driver use is disabled until
> > I roll another libdrm.
> 
> I've you want to test this, grab latest libdrm master, latest
> drm-intel-next branch from drm-intel, latest xf86-vide-intel master and
> put
> 
> #define DRM_MODE_OVERLAY_LANDED
> 
> at the top of the file xf86-vide-intel/src/i830_video.c
> 
> Happy testing, Daniel


I tested this.


I found the following problems:

* mplayer first run results in green picture, resizing makes it show the
overlay.
I suspect that it sets the colour key, after the start of the playback,
and this it is ignored.


* after a suspend to ram the overlay is broken.
It doesn't matter if I suspend the system while it is running.
It also doesn't matter if I never run it before suspend or not.


* If I run the overlay when it is broken, I see picture with broken YUV
offsets
that is black picture and blue/red rectangles over it.
also flashes of the green all over the picture can be seen.

* If I suspend the system after I have seen the broken overlay, it would
hang on resume.


My system is G965, using git tips of everything including the
drm-intel-next.


Compiz was turned off, but I was surprised to find it works very well
with both mplayer and vlc (even if cube is rotated, the overlay will be
clipped correctly and won't flicker, it is just not transformed because
its not possible)

Totem however, would actively paint black on top of colour key, thus
suppressing the overlay, still works fine in full-screen mode
It also sets this colorkey, thus recently posted patch to set the
colorkey to 0 won't help.... 
It also works fine without compiz.


Best regards,
	Maxim Levitsky