[Intel-gfx] [PATCH] restore render clock gating on resume

[Eric Anholt]

On Sat, 2009-11-07 at 10:52 -0500, Andrew Lutomirski wrote:
> On Thu, Nov 5, 2009 at 5:21 PM, Eric Anholt <eric at anholt.net> wrote:
> > On Fri, 2009-10-30 at 02:41 -0400, Andrew Lutomirski wrote:
> >> The render clock gating mode currently isn't restored when resuming,
> >> which causes high power consumption after a suspend/resume cycle on my
> >> laptop.
> >>
> >> Signed-off-by: Andy Lutomirski <luto at mit.edu>
> >
> > This looks pretty good, except that you're unconditionally
> > saving/restoring these regs, even though they only exist on gen4
> > hardware.  Could you fix it up to save/restore them for the same set of
> > hardware that the regs get set for?
> 
> Sure.  Or I can just call intel_init_clock_gating on resume.  Any preference?

It would mean tweaking it to avoid allocating a new RC6 page, but other
than that it sounds like a pretty good plan.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091107/ad4365ae/attachment.sig>