[Intel-gfx] [PATCH] drm/i915: let pin routine figure out appropriate alignment

[Jesse Barnes]

On Wed, 18 Nov 2009 18:33:30 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> Excerpts from Jesse Barnes's message of Wed Nov 18 17:58:42 +0000
> 2009:
> > From 8adb52b4529e777d4df0356bc2c8ef5453c2322e Mon Sep 17 00:00:00
> > 2001 From: Jesse Barnes <jbarnes at jbarnes-desktop.localdomain>
> > Date: Wed, 18 Nov 2009 09:56:25 -0800
> > Subject: [PATCH] drm/i915: let pin routine figure out appropriate
> > alignment
> > 
> > When this code got moved out of intel_pipe_set_base, it grew a
> > forced alignment of 256k, which wasn't always correct.  Remove that
> > and let the pin routine figure out the correct alignment for the
> > object (it should do this in just about every case).
> 
> I thought the only reason why pin() took an alignment parameter was so
> that we could specify a minimum alignment of 64k for untiled scan out
> buffers. Are we confident that this is not the case?

Well there are a few other places that want a specific alignment
(though mostly 4k so redundant).

But yeah we do need to preserve the 64k alignment for non-tiled
scanout.  I'll fix up the patch.

-- 
Jesse Barnes, Intel Open Source Technology Center