[Intel-gfx] [PATCH]drm/i915: handle failure path correctly for lvds

Eric Anholt eric at anholt.net
Wed Nov 25 23:11:33 CET 2009


On Tue, 17 Nov 2009 17:19:23 +0800, Shaohua Li <shaohua.li at intel.com> wrote:
> In failure path, make sure encoder is cleaned up, otherwise there is kernel oops.
> 
> Signed-off-by: Shaohua Li <shaohua.li at intel.com>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 05598ae..b272eb7 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -1093,5 +1093,6 @@ failed:
>  	if (intel_output->ddc_bus)
>  		intel_i2c_destroy(intel_output->ddc_bus);
>  	drm_connector_cleanup(connector);
> +	drm_encoder_cleanup(encoder);
>  	kfree(intel_output);
>  }

Applied.  Thanks!

But in the future, could you wrap commit messages to 80ish columns?  A
nice guideline is the wrapping of the comments below your commit message
in the editor buffer.



More information about the Intel-gfx mailing list