[Intel-gfx] [RFC/PATCH] render reclock quirks

Jesse Barnes jbarnes at virtuousgeek.org
Fri Oct 9 23:03:26 CEST 2009


On Fri, 9 Oct 2009 16:08:39 -0400
Andrew Lutomirski <luto at mit.edu> wrote:

> Add a quirk to enable render reclocking on a Thinkpad X200s.
> 
> Signed-off-by: Andy Lutomirski <luto at mit.edu>
> ---
> This probably shouldn't be applied as is, but it might be useful after
> some massaging.
> 
> It also changes the !SUPPORTS_EDP logic, which used to disable render
> reclocking on everything that doesn't support eDP (which is everything
> shipping, AFAICT).
> 
> It might be a better idea to just say "i915: VBIOS disables some power
> saving features.  See Documentation/whatever.txt if you want to help
> us enable it."
> 
> --Andy
> 
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c
> b/drivers/gpu/drm/i915/intel_bios.c
> index 4337414..6a4bff5 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -29,10 +29,15 @@
>  #include "i915_drm.h"
>  #include "i915_drv.h"
>  #include "intel_bios.h"
> +#include <linux/dmi.h>
> 
>  #define	SLAVE_ADDR1	0x70
>  #define	SLAVE_ADDR2	0x72
> 
> +static bool render_reclock_quirk_avail;
> +static bool force_render_reclock;
> +module_param(force_render_reclock, bool, 0400);
> +
>  static void *
>  find_section(struct bdb_header *bdb, int section_id)
>  {
> @@ -351,21 +356,51 @@ parse_driver_features(struct drm_i915_private
> *dev_priv, struct drm_device *dev = dev_priv->dev;
>  	struct bdb_driver_features *driver;
> 
> -	/* set default for chips without eDP */
> -	if (!SUPPORTS_EDP(dev)) {
> -		dev_priv->edp_support = 0;
> -		return;
> -	}

Ah yeah, thanks for submitting this.  I had this hunk locally but
failed to send it...  Definitely want this part at least.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list