[Intel-gfx] [PATCH 2/3] Xv overlay: set default color-key to black

Daniel Vetter daniel.vetter at ffwll.ch
Mon Oct 26 14:15:25 CET 2009


This way we avoid the dreaded blue. Furthermore most video players
use black as background, so no one can notice the color-key painting.
Leaking of the overlay outside the window is only possible when moving,
because the kernel should place it pixel-accurate.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 src/i830_driver.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/src/i830_driver.c b/src/i830_driver.c
index 867047c..7f8f5d4 100644
--- a/src/i830_driver.c
+++ b/src/i830_driver.c
@@ -803,10 +803,7 @@ static void I830XvInit(ScrnInfoPtr scrn)
 					&(intel->colorKey))) {
 		from = X_CONFIG;
 	} else {
-		intel->colorKey =
-		    (1 << scrn->offset.red) | (1 << scrn->offset.green) |
-		    (((scrn->mask.blue >> scrn->offset.blue) - 1) <<
-		     scrn->offset.blue);
+		intel->colorKey = 0;
 		from = X_DEFAULT;
 	}
 	xf86DrvMsg(scrn->scrnIndex, from, "video overlay key set to 0x%x\n",
-- 
1.6.4.3




More information about the Intel-gfx mailing list