[Intel-gfx] [PATCH] drm/i915: fix tiling on IGDNG

[Jesse Barnes]

On Tue, 01 Sep 2009 09:19:04 -0700
Keith Packard <keithp at keithp.com> wrote:

> On Tue, 2009-09-01 at 08:41 -0700, Jesse Barnes wrote:
> 
> > > -	if (!IS_I9XX(dev)) {
> > > +	if (IS_IGDNG(dev)) {
> > > +		/* On IGDNG whatever DRAM config, GPU always do
> > > +		 * same swizzling setup.
> > > +		 */
> > > +		swizzle_x = I915_BIT_6_SWIZZLE_9_10;
> > > +		swizzle_y = I915_BIT_6_SWIZZLE_9;
> > > +	} else if (!IS_I9XX(dev)) {
> > 
> > This doesn't seem equivalent... shouldn't it be if (IS_IGDNG(dev)
> > || !IS_9XX)?
> 
> This puts the IGDNG code above the old 9XX code -- see the else if at
> the end of this sequence.

Oh oops.  Fail at reading diffs today...

-- 
Jesse Barnes, Intel Open Source Technology Center