[Intel-gfx] [PATCH] Make DGA optional

Zhenyu Wang zhenyuw at linux.intel.com
Wed Sep 16 09:33:30 CEST 2009


On 2009.09.15 08:11:41 -0700, Keith Packard wrote:
> On Tue, 2009-09-15 at 15:14 +0800, Zhenyu Wang wrote:
> 
> > As DGA is optional in xserver, revert that one might crash X in start.
> > Or we just fake to init DGA proto, not sure if there's any DGA callbacks
> > that driver can use for framebuffer open later?
> 
> DGA isn't really optional; you'd have to recompile the X server to
> disable it. And, as we know, many applications depend on it (but only
> for input).
> 

Keith, are you ok with this one?

From 0449c374fd114d392412793e57cfdd8cefb7a504 Mon Sep 17 00:00:00 2001
From: Zhenyu Wang <zhenyuw at linux.intel.com>
Date: Wed, 16 Sep 2009 15:28:22 +0800
Subject: [PATCH] Always enable DGA

Partially revert fe7693c94a396b9d17bb66a000178750a432ce3a, which
did DGA disable in KMS case, which causes problem for games require
DGA for mouse tracking. So in KMS, we'll pass '-1' address for DGA
which is fine as nobody should use DGA for rendering now. oh, well.

Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
---
 src/i830_driver.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/i830_driver.c b/src/i830_driver.c
index e3e1ed2..5585df0 100644
--- a/src/i830_driver.c
+++ b/src/i830_driver.c
@@ -2739,8 +2739,7 @@ I830ScreenInit(int scrnIndex, ScreenPtr pScreen, int argc, char **argv)
    xf86SetBlackWhitePixels(pScreen);
 
 #ifdef XFreeXDGA
-   if (!pI830->use_drm_mode)
-       xf86DiDGAInit (pScreen, pI830->LinearAddr + pScrn->fbOffset);
+   xf86DiDGAInit (pScreen, pI830->LinearAddr + pScrn->fbOffset);
 #endif
 
    if (!I830AccelInit(pScreen)) {
-- 
1.6.3.3

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090916/daab568b/attachment.sig>


More information about the Intel-gfx mailing list