[Intel-gfx] [PATCH 1/5] drm/i915: Multiply the refresh by 1000 in TV mode validatiion

Zhenyu Wang zhenyuw at linux.intel.com
Tue Sep 22 08:54:00 CEST 2009


On 2009.09.21 17:18:40 +0800, yakui.zhao at intel.com wrote:
> From: Zhao Yakui <yakui.zhao at intel.com>
> 
> Now the actual refresh rate is returned by the function of drm_mode_vrefresh.
> So multiply the refresh rate by 1000 in TV mode validation.
> 
> At the same time the error is expanded from 10 to 1000.
> 
> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_tv.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index a6c686c..b8bff39 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -1082,7 +1082,8 @@ intel_tv_mode_valid(struct drm_connector *connector, struct drm_display_mode *mo
>  	const struct tv_mode *tv_mode = intel_tv_mode_find(intel_output);
>  
>  	/* Ensure TV refresh is close to desired refresh */
> -	if (tv_mode && abs(tv_mode->refresh - drm_mode_vrefresh(mode)) < 10)
> +	if (tv_mode && abs(tv_mode->refresh - drm_mode_vrefresh(mode) * 1000)
> +				< 1000)
>  		return MODE_OK;
>  	return MODE_CLOCK_RANGE;
>  }

Looks wrong to me, drm_mode_vrefresh() should return milli-hz already.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090922/82046c2f/attachment.sig>


More information about the Intel-gfx mailing list