[Intel-gfx] [PATCH] drm/i915: Initialize HDMI connectors as HDMI, not DVI.

[Zhenyu Wang]

On 2009.09.24 11:16:53 -0400, Adam Jackson wrote:
> On Thu, 2009-09-24 at 09:10 +0800, Zhenyu Wang wrote:
> > On 2009.09.23 15:08:29 -0400, Adam Jackson wrote:
> > > Signed-off-by: Adam Jackson <ajax at redhat.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_hdmi.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > index fa304e1..663ab6d 100644
> > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > @@ -223,7 +223,7 @@ void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
> > >  
> > >  	connector = &intel_output->base;
> > >  	drm_connector_init(dev, connector, &intel_hdmi_connector_funcs,
> > > -			   DRM_MODE_CONNECTOR_DVID);
> > > +			   DRM_MODE_CONNECTOR_HDMIA);
> > >  	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
> > >  
> > >  	intel_output->type = INTEL_OUTPUT_HDMI;
> > > -- 
> > > 1.6.4.2
> > > 
> > 
> > This is correct when 'HDMI' digital port is really made as HDMI port on board,
> > but we've seen boards which actually link up with DVI-D port. ;)
> 
> That's fine.  Labeling it as HDMI in RANDR will mean users will know
> they can use a DVI->HDMI converter and be able to send audio over that
> port.
> 

maybe the ideal solution would be to fix drm connector type assign, which should
be removed from connector init time, and provide new connector type setting function,
as the real physical connection type is normally known at connector probe time, e.g HDMI/DVI,
TV, etc.

For HDMI, we already have drm_detect_hdmi_monitor() helper.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090925/29ae0394/attachment.sig>