[Intel-gfx] [PATCH] drm/i915: Don't call intel_update_fbc from intel_crtc_cursor_set

Alexey Fisher bug-track at fisher-privat.net
Tue Sep 29 07:54:54 CEST 2009


Jesse Barnes schrieb:
> On Mon, 28 Sep 2009 16:25:11 -0700
> Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
>> On Mon, 28 Sep 2009 15:41:08 -0700
>> Brian Rogers <brian at xyzw.org> wrote:
>>
>>> Commit 74dff282 exposed this unnecessary call by causing a change in
>>> the failure path on i965 where framebuffer compression will be
>>> turned on and off on every cursor update. If you don't have the
>>> xf86-video-intel fix to avoid the blinking cursor effect, this is
>>> very slow.
>>>
>>> Symptoms were a far more noticeable cursor blink with every cursor
>>> image change combined with severe slowdown for animated cursors.
>>>
>>> Signed-off-by: Brian Rogers <brian at xyzw.org>
>>> Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org>
>> Should also go to stable.  Eric can you cc stable when you apply this?
> 
> Ignore this; this code isn't in 2.6.31 so stable cc isn't needed.
> 
> Jesse

This fix my "regression on vanilla kernel "drm/i915: framebuffer 
compression for pre-GM45" issue.
Thanks

Alexey



More information about the Intel-gfx mailing list