[Intel-gfx] [PATCH 7/7] drm/i915: enable DP/eDP for Sandybridge/Cougarpoint

[Zhenyu Wang]

On 2010.04.07 10:15:43 -0400, Adam Jackson wrote:
> 
> This is a curiously verbose way to write this.  I stared at the array
> indexing for about twenty seconds before I got it.  Seems a lot more
> straightforward to just do:
> 
> 	switch (train_set & (DP_TRAIN_VOLTAGE_SWING_MASK|DP_TRAIN_PRE_EMPHASIS_MASK)) {
> 	case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PREEMPHASIS_0:
> 		return EDP_LINK_TRAIN_400MV_0DB_SNB_B;
> 	case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PREEMPHASIS_6:
> 		return EDP_LINK_TRAIN_400MV_6DB_SNB_B;
> 	case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PREEMPHASIS_3_5:
> 		return EDP_LINK_TRAIN_600MV_3_5DB_SNB_B;
> 	case DP_TRAIN_VOLTAGE_SWING_800 | DP_TRAIN_PREEMPHASIS_0:
> 		return EDP_LINK_TRAIN_800MV_0DB_SNB_B;
> 	default:
> 		DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis-level\n");
> 		return EDP_LINK_TRAIN_400MV_0DB_SNB_B;
> 	}
> 

yeah, my bad, thanks for the comment!

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100408/235a4224/attachment.sig>