[Intel-gfx] [PATCH 2/2] drm/i915: Remove the bind in mmap_gtt_ioctl
Owain G. Ainsworth
zerooa at googlemail.com
Thu Apr 22 23:38:42 CEST 2010
It really won't affect faulting speed at all, and in rare cases may do
more than we needed in the first place. If we do need to map and we
aren't bound it will take *just as long* when the mmap happens as it
would on the ioctl being called.
Discussed with danvet and jbarnes.
Signed-Off-By: Owain G. Ainsworth <oga at openbsd.org>
---
drivers/gpu/drm/i915/i915_gem.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a9da182..935cd83 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1426,20 +1426,6 @@ i915_gem_mmap_gtt_ioctl(struct drm_device *dev, void *data,
args->offset = obj_priv->mmap_offset;
- /*
- * Pull it into the GTT so that we have a page list (makes the
- * initial fault faster and any subsequent flushing possible).
- */
- if (!obj_priv->agp_mem) {
- ret = i915_gem_object_bind_to_gtt(obj, 0);
- if (ret) {
- drm_gem_object_unreference(obj);
- mutex_unlock(&dev->struct_mutex);
- return ret;
- }
- list_add_tail(&obj_priv->list, &dev_priv->mm.inactive_list);
- }
-
drm_gem_object_unreference(obj);
mutex_unlock(&dev->struct_mutex);
--
1.6.5.7
More information about the Intel-gfx
mailing list