[Intel-gfx] [PATCH] drm/i915: Fix DDC bus selection for multifunction SDVO

[Adam Jackson]

On Fri, 2010-04-23 at 16:16 -0400, Adam Jackson wrote:

> So, instead of that, let's just use the DDC bus the child device table
> tells us to use.  I'm guessing at the bitmask and shifting from VBIOS
> dumps, but it can't possibly be worse.

Except,

> -	/* Corresponds to SDVO_CONTROL_BUS_DDCx */
> -	dev_priv->ddc_bus = 1 << num_bits;
> +	sdvo->ddc_bus = (mapping->ddc_pin & 0xf0) >> 4;

This should probably be = 1 << ((mapping->ddc_pin & 0xf0) >> 4);

Still, do whatever the BIOS does here.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100426/b1bdcfa3/attachment.sig>