[Intel-gfx] [PATCH] Revert "drm/i915: Don't enable pipe/plane/VCO early (wait for DPMS on)."

Eric Anholt eric at anholt.net
Fri Apr 30 01:42:37 CEST 2010


On Tue, 27 Apr 2010 10:55:44 -0700, Carl Worth <cworth at cworth.org> wrote:
> This reverts commit cfecde435dda78248d6fcdc424bed68d5db6be0b.
> 
> The commit was first created as an attempt to fix LVDS initialiazation
> on Ironlake. Testing revealed that it didn't fix that, but it was
> assumed to still be correct anyway.
> 
> Subsequent testing has revealed that this commit has caused other
> regressions:
> 
>   * Change in VBlank interrupt frequency causing 60% 3D performance regression
>     http://bugs.freedesktop.org/show_bug.cgi?id=27698
> 
>   * Black screen on G45
>     http://bugs.freedesktop.org/show_bug.cgi?id=27733
> 
> So revert this buggy code for now to revisit later when we can fix
> actual bugs without causing these regressions.

Since it's only in -next right now, do you have plans to look into why
this went wrong?  I'm concerned that we're reverting a bugfix to
"revisit later" with no plan to actually revisit later.

(Also, it seems that my laptop is much more reliable at modesetting on
the branch with the patch than the branch without the patch.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100429/0d969a51/attachment.sig>


More information about the Intel-gfx mailing list