[Intel-gfx] [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M

[Eric Anholt]

On Mon, 09 Aug 2010 18:04:50 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > Is this hack even needed?  I noticed on my 945GM that INSTDONE has a
> > stuck bit when I use this code, removing it didn't seem to have any
> > negative effects...
> 
> I'm not sure why we need to trigger a Sync on the GPU at this point, I
> just assumed it was one of those magic bits of code required to bring up
> the hardware.

Beginning a sync flush and continuing without waiting for the sync flush
to actually complete looks awfully bogus to me.  In the absence of
justification, I'd lean towards nuking this code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100809/254cd335/attachment.sig>