[Intel-gfx] Possible compilation error in commit 6ef3d42

Alexander Lam lambchop468 at gmail.com
Thu Aug 19 05:11:41 CEST 2010


Hi,

I think there may be a possibility of compilation error with drm-intel
commit 6ef3d42 if CONFIG_DEBUG_FS isn't selected.

commit 6ef3d4278034982c13df87c4a51e0445f762d316
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Aug 4 20:26:07 2010 +0100

    drm/i915: Capture the overlay status upon a GPU hang.

    v2: Add the interrupt status and address.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
    Signed-off-by: Eric Anholt <eric at anholt.net>

this commit uses seq_printf, which is defined in include/linux/seq_file.h,
which is included in include/drm/drm_mm.h only if CONFIG_DEBUG_FS is defined.

some wrapping with #ifdefs may be needed


Thanks for the great drivers,
Alexander Lam



More information about the Intel-gfx mailing list