[Intel-gfx] [PATCH] drm/i915: Addin-offset is an unreliable indicator of LVDS present

[Adam Jackson]

On Sun, 2010-08-22 at 19:06 +0100, Chris Wilson wrote:
> On Sun, 22 Aug 2010 18:23:21 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > My Samsung N210 has a VBT with DEVICE_TYPE_INT_LFP with a zero
> > addin-offset. With the check in place, the panel was declared absent.
> 
> Reviewing the history, the addin-offset was added to defend against
> incorrect LVDS entries in some VBIOSes. Can we rely on the no-lvds quirk
> table instead?

If you don't mind that the quirk table is wildly incomplete, sure.

AIM seems to be structured such that you have to have an addin to make
LVDS work.  I think the opregion change you posted is sufficient to find
the real VBT; having done that, the addin offset check is still valid.
If the platform would give us some actually reliable method of doing
LVDS detection then we could skip all this, but.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100823/5a80fd4d/attachment.sig>