[Intel-gfx] Intel 965 and Custom Resolutions

[Adam Jackson]

On Tue, 2010-08-31 at 14:19 +0000, The Fungi wrote:
> On Tue, Aug 31, 2010 at 09:49:53AM -0400, Adam Jackson wrote:
> > It's possible but improbable. What kernel are you running anyway?
> 
> That system had 2.6.35-rc5 i686 with PAE at the last boot (needed
> some patches for Wacom BT/HID support which got integrated in rc4 or
> rc5). I'll most likely replace that with a 2.6.35 release version
> next time I get around to rebooting, unless 2.6.36 is out by then.

Sigh, okay.  You should be able to get the complete EDID block out
of /sys/class/drm/card0/*/edid, at least if you have in your kernel:

commit 7466f4cc508878a8328dff1c328a2b4108888d2e
Author: Adam Jackson <ajax at redhat.com>
Date:   Mon Mar 29 21:43:23 2010 +0000

    drm/edid: Remove arbitrary EDID extension limit
    
    Signed-off-by: Adam Jackson <ajax at redhat.com>
    Signed-off-by: Dave Airlie <airlied at redhat.com>

which should already be present in 2.6.35.  But the X driver looks like
it never sets MONITOR_EDID_COMPLETE_RAWDATA, which means the X core
doesn't know that any sections beyond the first are present, so it won't
ever hand back more than 128 bytes to clients.  Boo.

This should help:

---
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 6f7e5f1..886c58f 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -731,6 +731,7 @@ drmmode_output_get_modes(xf86OutputPtr output)
 	drmModePropertyPtr props;
 	struct fixed_panel_lvds *p_lvds;
 	drmModeModeInfo *mode_ptr;
+	xf86MonPtr mon = NULL;
 
 	/* look for an EDID property */
 	for (i = 0; i < koutput->count_props; i++) {
@@ -751,14 +752,13 @@ drmmode_output_get_modes(xf86OutputPtr output)
 		drmModeFreeProperty(props);
 	}
 
-	if (drmmode_output->edid_blob)
-		xf86OutputSetEDID(output,
-				  xf86InterpretEDID(output->scrn->scrnIndex,
-						    drmmode_output->edid_blob->data));
-	else
-		xf86OutputSetEDID(output,
-				  xf86InterpretEDID(output->scrn->scrnIndex,
-						    NULL));
+	if (drmmode_output->edid_blob) {
+		mon = xf86InterpretEDID(output->scrn->scrnIndex,
+					drmmode_output->edid_blob->data);
+		if (drmmode->edid_blob->length > 128)
+			mon->flags |= MONITOR_EDID_COMPLETE_RAWDATA;
+	}
+	xf86OutputSetEDID(output, mon);
 
 	/* modes should already be available */
 	for (i = 0; i < koutput->count_modes; i++) {
---

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100831/8703e675/attachment.sig>