[Intel-gfx] [PATCH] drm/i915: unconditionally unlock panel regs

Chris Wilson chris at chris-wilson.co.uk
Tue Dec 14 21:45:14 CET 2010


On Tue, 14 Dec 2010 12:17:59 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> In the panel_on function we skip everything if the panel is already
> powered up.  However, if it's powered up but not unlocked, subsequent
> register writes may fail.
> 
> So unlock the regs regardless of the panel state to allow other mode
> setting programming to occur normally.

That looks to be consistent with other [ab]users of PP_CONTROL. Can you
tidy up the function to remove the duplicate code afterwards?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list