[Intel-gfx] [PATCH] i915: Modify for pineview clock source

[Dave Airlie]

> Chris,
>
> I am happy to use the ssc frequency setting code and expand beyond pineview
> (although I can't really test those configurations), but Im not sure what to
> do about the high_speed flag. This would normally come from the BDB general
> features ssc_freq flag. Since the code is to set defaults that will be used
> in the absence of VBIOS/VBT would it be acceptable to just set high_speed to
> 1 when I call intel_bios_ssc_frequency to configure the speed, so that for
> pineview it matches the original code? This would be correct for the
> machines we know that do not have VBIOS and is otherwise as arbitrary as
> using 0.

I have to say they are both seemingly arbitrary and pointless.

What happens if I say my pineview LVDS panel needs it the other way
and I don't have a VBIOS either? who wins?

Really the kernel should just fail if the parameter isn't available
from the VBIOS, and maybe you could add some sort of command line or
even openfirmware type table to store this info.

Having the driver making crappy decision because someone thought not
shipping a bios with the hw details in it is hardly what I call
engineering.

Dave.