[Intel-gfx] [PATCH] drm/i915: support low power watermarks on Ironlake

[Chris Wilson]

On Tue, 21 Dec 2010 13:10:23 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> This patch actually makes the watermark code even uglier (if that's
> possible), but has the advantage of sharing code between SNB and ILK at
> least.  Longer term we should refactor the watermark stuff into its own
> file and clean it up now that we know how it's supposed to work.
> 
> Supporting WM2 on my Vaio reduced power consumption by around 0.5W, so
> this patch is definitely worthwhile (though it also needs lots of test
> coverage).

I tweaked the patch to pass the watermark structs through to the check
routine. The box survives s2ram, but I have now also experienced the
mysterious slow down after resuming.

Pushed to -next for wider testing,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre