[Intel-gfx] [PATCH 04/11] drm/i915: fixup active list locking in object_unbind

[Chris Wilson]

On Mon,  1 Feb 2010 13:59:19 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> All other accesses take this spinlock, so do this here, too.

Can we just kill this spinlock? Please... It only gives a false sense of
security wrt to /debug/ so why bother with the pretence. Given that we now
have hang-check, struct_mutex livelocks are a thing of the past and we can
start correctly taking the struct_mutex for /debug/. If you really want to
prevent a hang on the mutex, when reading /debug/:

  if (!mutex_trylock (&dev->struct_mutex))
     eturn -EBUSY;
-ickle

P.S. Note that there are move places that actually need to hold this
spinlock...

-- 
Chris Wilson, Intel Open Source Technology Centre