[Intel-gfx] [PATCH] drm/i915: untangle page flip completion

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 4 20:25:27 CET 2010


On Tue, 26 Jan 2010 14:40:05 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> When a new page flip is requested, we need to both queue an unpin for
> the current framebuffer, and also increment the flip pending count on
> the newly submitted buffer.
> 
> At flip finish time, we need to unpin the old fb and decrement the flip
> pending count on the new buffer.
> 
> The old code was conflating the two, and led to hangs when new direct
> rendered apps were started, replacing the existing frame buffer.  This
> patch splits out the buffers and prevents the hangs.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>

I've had a good read through and the code does indeed make a lot more
sense now. :)

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list