[Intel-gfx] [PATCH] drm/i915: Increase fb alignment to 64k

[Chris Wilson]

On Tue, 09 Feb 2010 15:13:13 +0000, Barry Scott <barry.scott at onelan.co.uk> wrote:
> On 09/02/10 14:14, Chris Wilson wrote:
> > -	ret = i915_gem_object_pin(fbo, PAGE_SIZE);
> > +	ret = i915_gem_object_pin(fbo, 64*1024);
> >   	if (ret) {
> >   		DRM_ERROR("failed to pin fb: %d\n", ret);
> >   		goto out_unref;
> >    
> What is page size gets defined to be bigger then 64k in the future?
> max( 64*1024, PAGE_SIZE ) maybe?

Urm, because the alignment required by the hardware has nothing to do
with PAGE_SIZE. And if there is a minimum alignment imposed by the
allocator, then that is solely the responsibility of the allocator. And
it had better not interfere with the hardware requirements...
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre