[Intel-gfx] [PATCH resend] drm/i915: enable memory self refresh on 9xx

Daniel Vetter daniel at ffwll.ch
Fri Feb 19 00:20:06 CET 2010


On Fri, Jan 29, 2010 at 02:11:49PM -0800, Eric Anholt wrote:
> > Hi, Eric
> > 
> > The patch you committed at
> > http://git.kernel.org/?p=linux/kernel/git/anholt/drm-intel.git;a=commit;h=72ddbd39f39b3cc5f1f661f97e67f2a497c4d57a
> > is an old version. It still has a bug that may cause GPU hang in my test. Because
> > that so far we have two idle timers, one is gpu idle timer and the other is 
> > crtc idle timer, we should disable SR when either of them changing to busy, 
> > not just for crtc idle timer. Here is the update version. Please review.
> 
> Thanks for catching that.  I've rebased this one in instead.

Looks like rebasing broke this patch in current drm-intel-next:

drivers/gpu/drm/i915/intel_display.c: In function ‘i9xx_update_wm’:             
drivers/gpu/drm/i915/intel_display.c:2778: error: ‘IS_I915GM’ undeclared (first use in this function)

Theres simply a (dev) argument missing right afterwards.

-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list