[Intel-gfx] [PATCH] drm/i915: remove chatty execbuf failure message

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 14 22:32:42 CET 2010


On Thu, 14 Jan 2010 13:16:51 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> -ERESTARTSYS is a normal return value from the flip pending wait routine.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_gem.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 21950ef..31eb5b5 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4001,7 +4001,7 @@ i915_gem_execbuffer(struct drm_device *dev, void *data,
>  				  args->buffer_count, ret);
>  		}
>  	} else {
> -		DRM_ERROR("i915_gem_do_execbuffer returns %d\n", ret);
> +		DRM_DEBUG("i915_gem_do_execbuffer returns %d\n", ret);
>  	}
Can we just kill this error message? It goes straight to userspace which
also prints it out. (And I claim it has not once contained a useful bit of
information which is not printed out earlier.)
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list