[Intel-gfx] [PATCH] drm/i915: initialize pending_flip count

Jesse Barnes jbarnes at virtuousgeek.org
Thu Jan 14 22:36:14 CET 2010


On Thu, 14 Jan 2010 21:33:41 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Thu, 14 Jan 2010 13:17:32 -0800, Jesse Barnes
> <jbarnes at virtuousgeek.org> wrote:
> > Out of paranoia.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/i915_gem.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c
> > b/drivers/gpu/drm/i915/i915_gem.c index 31eb5b5..8526850 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -4336,6 +4336,7 @@ int i915_gem_init_object(struct
> > drm_gem_object *obj) INIT_LIST_HEAD(&obj_priv->list);
> >  	INIT_LIST_HEAD(&obj_priv->fence_list);
> >  	obj_priv->madv = I915_MADV_WILLNEED;
> > +	atomic_set(&obj_priv->pending_flip, 0);
> 
> Don't trust kzalloc() then, hmm? Justify the inconsistency!
> -ickle

Well more paranoid about weird debug representations of atomic_*, but
yeah it's irrational paranoia.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list