[Intel-gfx] [PATCH 09/11] drm/i915: fixup execbuf failure path

[Chris Wilson]

On Fri, 15 Jan 2010 13:24:16 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Objects were unconditionally unreferenced in the error path.
> Fix this up like with the object pinning.
> 
[snip]

> -	for (i = 0; i < args->buffer_count; i++) {
> +	for (i = 0; i < referenced; i++) {
>  		if (object_list[i]) {
>  			obj_priv = object_list[i]->driver_private;
>  			obj_priv->in_execbuffer = false;

If this is truly an issue, then why not take advantage of the
if(object_list[i]) ? The simplest fix here would be to just
  if (!object_list) break;
instead.
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre