[Intel-gfx] [PATCH 08/11] drm/i915: fixup i915_gem_evict_everything to actually evict everything

Daniel Vetter daniel at ffwll.ch
Fri Jan 15 14:47:24 CET 2010


On Fri, Jan 15, 2010 at 01:04:27PM +0000, Chris Wilson wrote:
> This patch is just ugly. It was very difficult to spot that the real
> change was to add a second flush and wait.

It's at least a gross hack, I agree ...
> 
> We can instead manage the write_domains on the active/flushing lists more
> intelligently, with a gpu_write_list and avoid the need for a double
> flush/wait. Just requires one more list to manage...

At first I tried to split the active_list into a read and a write part.
But that grew ugly even more, due to the due dirty objects then sitting on
2 different lists, depending upon whether they're used by the gpu or not.

Drop my patch, I'll see into updateing yours.

-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list