[Intel-gfx] [PATCH] drm/i915: extract fence stealing code

Chris Wilson chris at chris-wilson.co.uk
Sat Jan 16 00:54:23 CET 2010


On Fri, 15 Jan 2010 23:54:22 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> The spaghetti logic in there tripped up my brain's code parser for a
> few secs. Prevent this from happening again by extracting the fence
> stealing code into a seperate functions. IMHO this slightly clears up
> the code flow.
> 
> v2: Beautified according to ickle's comments.
> 
> v3: ickle forgot to flush his comment queue ... Now there's also a
> we-are-paranoid BUG_ON in there.
> 
> v4: I've forgotten to switch on my brain when doing v3. Now the BUG_ON
> actually checks something useful.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Much better than my suggestion, ta.
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list