[Intel-gfx] [PATCH 2/6] drm/i915: Add update_wm callback for pineview to update watermark

[Li, Shaohua]

>-----Original Message-----
>From: Eric Anholt [mailto:eric at anholt.net]
>Sent: Saturday, January 16, 2010 5:25 AM
>To: Zhao, Yakui
>Cc: intel-gfx at lists.freedesktop.org; Zhao, Yakui; Li, Shaohua
>Subject: Re: [PATCH 2/6] drm/i915: Add update_wm callback for pineview to
>update watermark
>
>On Wed, 13 Jan 2010 22:10:51 +0800, yakui.zhao at intel.com wrote:
>> From: Zhao Yakui <yakui.zhao at intel.com>
>>
>> Now we don't define the update_wm callback function explicitly for
>> pineview platform. But as it also belongs to mobile platform, we will
>> use the function of i9xx_update_wm function to update its watermark
>again
>> after we configure the watermark. This is incorrect.
>>
>> So we will add a update_wm callback function for pineview to update
>watermark.
>> In such case only one function is used, in which it will calculate the
>self
>> refresh watermark when only one single display plane is used. At the
>same time
>> we will also calculate the watermark for display plane/cursor when it
>doesn't
>> enter the self-refresh.
>>
>> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
>> cc: Li Shaohua <shaohua.li at intel.com>
>> ---
>> According to the spec the memory will enter the self-refresh state only
>when
>> display plane is used and the CPU enters the deep C-state(C3). So this
>patch
>> won't disable the self-refresh bit explicitly in this update_wm callback.
>>
>> The second is that I also update the watermark for display plane/cursor
>when
>> it doesn't enter the self-refresh. And I use the fifo size defined for
>945gm
>> to calculate the corresponding watermark. Before this patch, the display
>> plane/cursor will use the default value when the memory doesn't enter
>the
>> self-refresh.
>
>Looking for Shaohua's Reviewed-by on this one, or a note from him that
>he won't be able to review it.
Looks fine to me.

Thanks,
Shaohua