[Intel-gfx] [PATCH] drm/i915: Fix the device info of Pineview

[Zhenyu Wang]

On 2010.01.21 18:45:46 +0800, Li Peng wrote:
> Pineview doesn't has CXSR and need GTT-based hardware status page.
> It fixes a X boot hung issue on Pinview since commit cfdf1f
> 
> Signed-off-by: Li Peng <peng.li at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 46d8896..ecac882 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -120,7 +120,7 @@ const static struct intel_device_info intel_gm45_info = {
>  
>  const static struct intel_device_info intel_pineview_info = {
>  	.is_g33 = 1, .is_pineview = 1, .is_mobile = 1, .is_i9xx = 1,
> -	.has_pipe_cxsr = 1,
> +	.need_gfx_hws = 1,
>  	.has_hotplug = 1,
>  };
>  

Pineview does have CxSR feature, which is to do self-refresh when in Cx idle
state, it's also mentioned as 'big fifo' in some place, as we need to adjust
fifo watermark to be in SR mode longer and not disturb memory controller often.

So the 'has_pipe_cxsr' looks doesn't really mean CxSR feature here. Although pineview
got many special case in code, which still enables CxSR. Looks we should use
'has_pipe_cxsr' for its real purpose and rename the current to something like
'has_pipe_refresh_rate_switch'. It's a mess now, but I hope no real break for hw,
as I never run a pineview...

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100126/8ab0911d/attachment.sig>