[Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

[Keith Packard]

On Fri, 02 Jul 2010 17:19:18 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard <keithp at keithp.com> wrote:
> > On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > 
> > > This looks like the responsibility of miCloseScreen(). Are we failing to
> > > chain up properly?
> > 
> > I don't think miCloseScreen (or fbCloseScreen) can do this -- before
> > we're called, rendering may not have been finished, after we're called,
> > the acceleration code is shut down and pixmaps cannot be freed.
> 
> That sounds true, and deserves a comment in the code. It doesn't explain
> why fbCloseScreen() calls free(screen->devPrivate) instead of
> miCloseScreen() and causing the leak in the first place... :)

yeah, miCloseScreen frees the pixmap, but that's too late...

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100703/5331257e/attachment.sig>