[Intel-gfx] [PATCH] drm/agp/i915: trim stolen space to 32M

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 8 18:42:19 CEST 2010


On Thu, 8 Jul 2010 17:37:10 +0100, Simon Farnsworth <simon.farnsworth at onelan.com> wrote:
> On Thursday 8 July 2010, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > Some BIOSes will claim a large chunk of stolen space.  Unless we
> > reclaim it, our aperture for remapping buffer objects will be
> > constrained.  So clamp the stolen space to 32M and ignore the rest.
> > 
> > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15469 among others.
> > 
> > Adding the ignored stolen memory back into the general pool using the
> > memory hotplug code is left as an exercise for the reader.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> FWIW, given how simple the code actually is:
> Reviewed-by: Simon Farnsworth <simon.farnsworth at onelan.com>

Heh, you were meant to say:

"What? Export a magic parameter from intel-gtt.c to indicate how much
space to remove from the aperture guestimate, but not replace the *broken*
code in i915_dma.c with an interface from intel-gtt.c to query and control
the populated GTT more precisely?"

;-)
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list