[Intel-gfx] [PATCH] drm/i915: Fix panel fitting regression since 734b4157

Jesse Barnes jbarnes at virtuousgeek.org
Sun Jul 18 03:09:44 CEST 2010


On Sat, 17 Jul 2010 12:46:08 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> The crtc mode fixup is run after the encoders adjust the mode to fit
> on their output, so don't reset the mode!
> 
> Fixes:
> 
>   Bug 29057 - display corruption under 800x600 on netbook
>               (1024x600) with 'Full Aspect' scaling
>   https://bugs.freedesktop.org/show_bug.cgi?id=29057
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 68dcf36..77e1c75 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2356,8 +2356,6 @@ static bool intel_crtc_mode_fixup(struct
> drm_crtc *crtc, if (mode->clock * 3 > 27000 * 4)
>  			return MODE_CLOCK_HIGH;
>  	}
> -
> -	drm_mode_set_crtcinfo(adjusted_mode, 0);
>  	return true;
>  }
>  

Wow old breakage, I guess we don't test the other fitting modes very
well.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list