[Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

Linus Torvalds torvalds at linux-foundation.org
Sun Jul 18 18:59:28 CEST 2010

On Sun, Jul 18, 2010 at 7:27 AM, M. Vefa Bicakci <bicave at superonline.com> wrote:
> After hours of testing I came up with the following result: We need
> to have the __GFP_RECLAIMABLE flag in addition to GFP_HIGHUSER.

Thanks for the extensive testing, and I'm committing the one-liner to
add it, and cc'ing it to stable. I'm pretty certain that there is
something overly fragile in the i915 driver that this flag makes so
much of a difference, but at the same time I'm actually happy that
it's that reclaimable flag, because at least that one was always the
"conceptually makes sense" one.

So I suspected it would be some low-memory issue and the flag that
woudl turn out to matter would be the NOMEMALLOC one, but I'm happy to
have been wrong. Adding __GFP_RECLAIMABLE is sane, although I really
would like to understand why the i915 driver apparently cares so
deeply about the allocation/freeing patterns.

But whatever. Thanks again for being such a thorough tester,


More information about the Intel-gfx mailing list