[Intel-gfx] [PATCH] convert intel_ring_begin count to dword

Eric Anholt eric.anholt at intel.com
Tue Jun 15 03:29:29 CEST 2010


On Sat, 12 Jun 2010 17:40:24 +0800, Zou Nan hai <nanhai.zou at intel.com> wrote:
> convert intel_ring_begin count to dword,
> fix some wrong intel_ring_begin size.

Please don't repeat the first line of the commit message twice, but
please do prepend "drm/i915: " for patches to the DRM.  When I applied
your patch, I got:

commit 186c799be39c5bbc845fe2eccdb87d0ad315e521
Author: Zou Nan hai <nanhai.zou at intel.com>
Date:   Sat Jun 12 17:40:24 2010 +0800

    convert intel_ring_begin count to dword
    
    convert intel_ring_begin count to dword,
    fix some wrong intel_ring_begin size.
    
    Signed-off-by: Zou Nan hai <nanhai.zou at intel.com>
    Signed-off-by: Eric Anholt <eric at anholt.net>

I rewrote it to be:

commit be26a10bd10271b4a810ece2e540c0cdd77881bc
Author: Zou Nan hai <nanhai.zou at intel.com>
Date:   Sat Jun 12 17:40:24 2010 +0800

    drm/i915: Fix incorrect intel_ring_begin size in BSD ringbuffer.
    
    The ring_begin API was taking a number of bytes, while all of our
    other begin/end macros take number of dwords.  Change the API over to
    dwords to prevent future bugs.
    
    Signed-off-by: Zou Nan hai <nanhai.zou at intel.com>
    Signed-off-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100614/a7f9032a/attachment.sig>


More information about the Intel-gfx mailing list