[Intel-gfx] [PATCH] drm/i915: encoder/connector internal structure rework

[Zhenyu Wang]

On 2010.03.02 11:31:55 +0800, ykzhao wrote:
> > 
> > This actually doesn't conflict with current code, as we already assumed
> > only one type of connector can work with SDVO encoder for a single time, 
> > the 'attached_output' is set to response value for GetAttachedDisplays request.
> 
> Yes. The attached_output can reflect the external request value of
> GetAttachedDisplays. And it can work.
> 
> But then we will create two connectors with the same connector type for
> one SDVO encoder. Maybe one of the two connectors is never used. 

No, they have their own different SDVO_OUTPUT_XXX flag, which is used in detection.

> 
> If we can group the same type of capability bit and create one
> connector, we can update the correct attached_output according to the
> response of GetAttachedDisplay request.
> 

As each connector already has own type flag, current code seems easy enough to me.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100302/30b8a942/attachment.sig>