[Intel-gfx] [PATCH] drm/i915: encoder/connector internal structure rework (v2)

[Zhenyu Wang]

On 2010.03.02 23:05:11 +0800, ykzhao wrote:
> It seems that there exist the following issues about the multi-function
> SDVO.
>    1. the flag of needs_tv_clock is not updated according to the
> external connected device. If it is used as SDVO-VGA, the flag of
> needs_tv_clock should be cleared.

yeah, it should be handled like for 'has_tv' setting in detection.

>    2. The flag of has_tv/has_lvds in sdvo_encoder private structure is
> used to check whether the corresponding property should be destroyed in
> course of connector cleanup. As the flag of has_tv/has_lvds is stored in
> sdvo_encoder, it is already free when accessing them in connector
> cleanup function.  At the same time the flag of has_tv/has_lvds will be
> updated in course of SDVO detection. Maybe at some cases we can't handle
> the corresponding SDVO property correctly.

yeah, I would cleanup it like this. The 'has_tv/lvds' flag is for SDVO encoder
to do any special action for current active output, like clock setting on SDVO
TV. And each connector has 'output_flag' for its type, so connector's property
handling will only need to check that, it's not related to what kind of output
encoder drives now.

> 
> Another little issue is that the HDMI ddcbus is not free in course of
> HDMI connector cleanup. 
> 

Good catch!

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100303/a64b5cbb/attachment.sig>