[Intel-gfx] [PATCH 2/2] drm/i915: encoder/connector internal structure rework (v4)

[Andrew Lutomirski]

On Thu, Mar 4, 2010 at 3:07 AM, Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> This trys to rework intel driver's internal encoder/connector handling
> code by replacing 'struct intel_output' with specific 'intel_encoder'
> and 'intel_connector' structure, which according to 'drm_encoder' and
> 'drm_connector' respectively.
>
> The reason to do this is to implement multiple connector types for one
> single SDVO device, so one 'intel_encoder' would be able to driver multiple
> 'intel_connector' objects. We might be able to change internal code in
> SDVO only for this, but I found it would bring lot of confusing and SDVO
> only home-made stuff, and still need to hack driver common code here and
> there. Which lead me to this more intrusive solution, but I hope would be
> the most clean one.
>
> With this, each supported connector type on SDVO device will be created
> as a new 'intel_connector', and all attached to one 'intel_encoder' for
> its SDVO port. Then SDVO encoder will handle SDVO protocol stuff, and each
> connector does its easy part now like detection is only to check if current
> active output is itself.
>
> As it removes 'struct intel_output' completely, so patch is quite long
> and mostly for renaming old struct to new one. For making it still bisectable
> I think it has to be put in one place.
>

Should I expect this to fix my hotplug storm issues?  I currently have
HDMI, SDVO, and DP patched out of my kernel.  If so, I can try to
apply your patch and test, both for stability and to see whether my DP
docking port still works.  (I'm a little scared of running
merge-window kernels on machines that I need for work.)

--Andy